orpiske commented on code in PR #13392:
URL: https://github.com/apache/camel/pull/13392#discussion_r1514603809
##########
components/camel-test/camel-test-junit5/src/main/java/org/apache/camel/test/junit5/CamelTestSupport.java:
##########
@@ -140,11 +138,13 @@ public long timeTaken() {
public void beforeEach(ExtensionContext context) throws Exception {
currentTestName = context.getDisplayName();
globalStore = context.getStore(ExtensionContext.Namespace.GLOBAL);
+ setUp();
Review Comment:
I think we should rename this base class. IMHO, it can be very confusing to
have this method named as `setup` and not running automatically as part of the
`BeforeEach`.
I base this on the reasoning that the name may imply the former way of
setting up tests from JUnit 4.
Wdyt?
##########
components/camel-test/camel-test-junit5/src/main/java/org/apache/camel/test/junit5/CamelTestSupport.java:
##########
@@ -140,11 +138,13 @@ public long timeTaken() {
public void beforeEach(ExtensionContext context) throws Exception {
currentTestName = context.getDisplayName();
globalStore = context.getStore(ExtensionContext.Namespace.GLOBAL);
+ setUp();
Review Comment:
I think we should rename this base method. IMHO, it can be very confusing to
have this method named as `setup` and not running automatically as part of the
`BeforeEach`.
I base this on the reasoning that the name may imply the former way of
setting up tests from JUnit 4.
Wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
