lburgazzoli commented on PR #5218: URL: https://github.com/apache/camel-k/pull/5218#issuecomment-1980284841
> > Maybe, should we honor the `mount.hot-reload` option ? In some cases, the user may not have full control of the configmap/secrets i.e. when those resources are generated by another controller. > > The option is already used in the controller to wake up the Integration and kick the logic: > > https://github.com/apache/camel-k/blob/825f0ce6aaf3a52c2620f8efab31b8167973c5fc/pkg/controller/integration/integration_controller.go#L191 > - do you think we need to include this again in the `getIntegrationSecretAndConfigmapResourceVersions` func? I think it may be a duplicated check, but definetely it's something that should not hurt. I don't have the full picture but my reasoning is that, the hot reload flag prevents a reconciliation to happen but, in case the reconciliation is triggered by i.e. a non destructive trait change, then we ends up in the same case as https://github.com/apache/camel-k/issues/5192, which effectively will end up in a restart/reload. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
