squakez opened a new pull request, #5216:
URL: https://github.com/apache/camel-k/pull/5216

   <!-- Description -->
   
   This PR addresses a wrong assumption I made in the development of #5153 
where we were naively storing the spec after their execution. However, this is 
not necessarily true, as the trait execution may change certain parameters 
originally introduced by the user. With this PR we store correctly the executed 
traits and we make sure to use the `.status.trait` where it would be required 
for Integration comparisons.
   
   This PR also proves another wrong assumption I made during the development 
of #5180 where we introduced a check for a possible drift in the 
`.status.trait`. However, this should never be checked for a change as it's an 
internal status controlled by the operator and it would wrongly trigger a new 
rebuild when the operator stores the `.status.trait` value. The operator should 
normally monitor for changes in the `.spec` only in this case in order to 
trigger a rebuild if it is required.
   
   
   
   <!--
   Enter your extended release note in the below block. If the PR requires
   additional action from users switching to the new release, include the string
   "action required". If no release note is required, write "NONE". 
   
   You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" 
to make sure
   the text is added to the right section of the release notes. 
   -->
   
   **Release Note**
   ```release-note
   chore(traits): store executed traits
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to