mvolf commented on issue #962:
URL: https://github.com/apache/camel-karavan/issues/962#issuecomment-1975922783

   @mgubaidullin I just checked with the latest code from main branch. This is 
on docker and the "Deploy" button is enabled all of the time, even if user 
still didn't build the project or mark the default image for deployment.
   Since the "Deploy" button is always enabled user is able to click it and is 
in this case presented with an error.
   
   Here's a few screenshots:
   
   - user didn't build the project:
   
   
![no_build](https://github.com/apache/camel-karavan/assets/798213/c3dc1c77-a869-4cf5-a5b4-2fc9e523435d)
   
   
   - error when user click deploy without the build (here it's also visible 
that the "Deploy" button is enabled):
   
   
![no_build_error](https://github.com/apache/camel-karavan/assets/798213/38ba15bc-58c5-4a4e-b3bc-99d5488ec390)
   
   
   - user builds the project but doesn't mark the newly created image as 
default:
   
   
![no_default_image](https://github.com/apache/camel-karavan/assets/798213/55b1c418-e696-4489-9608-a90c0c9fda1d)
   
   
   - error when user click deploy without the default image (again "Deploy" 
button is enabled):
   
   
![no_default_image_error](https://github.com/apache/camel-karavan/assets/798213/5e8b22b6-8cce-44c8-a88e-47fabf5f8437)
   
   
   My conclusion is that the "Deploy" button should be enabled only if all 
requirements for the deployment are met. In other words, it should be enabled 
only if user built the project and marked the default image.
   Currently, user is presented with an error message which means nothing to 
them and is in fact very misleading.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to