squakez commented on code in PR #5198:
URL: https://github.com/apache/camel-k/pull/5198#discussion_r1508664654
##########
pkg/builder/quarkus.go:
##########
@@ -163,53 +158,6 @@ func GenerateQuarkusProjectCommon(runtimeVersion string,
quarkusVersion string,
},
)
- // Add all the properties from the build configuration
- p.Properties.AddAll(buildTimeProperties)
-
- // Quarkus build time properties
- buildProperties := make(map[string]string)
-
- // disable quarkus banner
- buildProperties["quarkus.banner.enabled"] = "false"
-
- // camel-quarkus does route discovery at startup, but we don't want
- // this to happen as routes are loaded at runtime and looking for
- // routes at build time may try to load camel-k-runtime routes builder
- // proxies which in some case may fail.
- buildProperties["quarkus.camel.routes-discovery.enabled"] = "false"
-
- // required for to resolve data type transformers at runtime with
service discovery
- // the different Camel runtimes use different resource paths for the
service lookup
- buildProperties["quarkus.camel.service.discovery.include-patterns"] =
"META-INF/services/org/apache/camel/datatype/converter/*,META-INF/services/org/apache/camel/datatype/transformer/*,META-INF/services/org/apache/camel/transformer/*"
-
- // copy all user defined quarkus.camel build time properties to the
quarkus-maven-plugin build properties
- for key, value := range buildTimeProperties {
- if strings.HasPrefix(key, "quarkus.camel.") {
- buildProperties[key] = value
- }
- }
-
- configuration := v1.PluginProperties{}
- configuration.AddProperties("properties", buildProperties)
-
- // Plugins
- p.Build.Plugins = append(p.Build.Plugins,
Review Comment:
Should be fixed now. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
