davsclaus commented on code in PR #1097:
URL:
https://github.com/apache/camel-spring-boot/pull/1097#discussion_r1508649146
##########
core/camel-spring-boot/src/main/java/org/apache/camel/spring/boot/CamelAutoConfiguration.java:
##########
@@ -189,6 +197,12 @@ public static CamelContext
doConfigureCamelContext(ApplicationContext applicatio
// and call after all properties are set
DefaultConfigurationConfigurer.afterPropertiesSet(camelContext);
+ // apply custom configurations if any
+ // TODO: this must be evaluated as I don't know if it makes sense here.
+ contextCustomizers.stream()
+ .sorted(Comparator.comparing(CamelContextCustomizer::getOrder))
+ .forEach(c -> c.configure(camelContext));
Review Comment:
That method does lookup various beans and configure them. I would think
`CamelContextCustomizer` should be there instead.
Also if you think to make it cleaner, we can add a new method on
`DefaultConfigurationConfigurer` just for these customizers, and invoke it
after the method above. And then you also need to remember to call this method
from Camel Spring Boot (and the same for Quarkus unless it does some special
magic for this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
