squakez commented on code in PR #5200:
URL: https://github.com/apache/camel-k/pull/5200#discussion_r1506304897
##########
pkg/cmd/install.go:
##########
@@ -414,6 +415,24 @@ func (o *installCmdOptions) setupOperator(
platformName)
}
+ // Choose an architecture specific operator/base image when not already
given explicitly
+ //
+ arch, err := kubernetes.NodeArchLookup(o.Context, c)
Review Comment:
I don't think the CLI should inspect the node. You're assuming it has
privileges that it should not have.
##########
pkg/util/defaults/defaults.go:
##########
@@ -44,5 +44,10 @@ const (
installDefaultKamelets = true
)
+// Maps architecture variants for common base images
+var baseImageArchMapping = map[string]string{
+ "eclipse-temurin:17-arm64":
"eclipse-temurin:17@sha256:a90cec83bb9b9ab19a63e377b20c3aa4e076b16c52d36e83c62c451b6d034e22",
Review Comment:
We cannot hardcode this value. We need to drive this information from
configuration as it happens for the other variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
