orpiske commented on code in PR #13040:
URL: https://github.com/apache/camel/pull/13040#discussion_r1481681845
##########
core/camel-core-model/src/main/java/org/apache/camel/model/ThrottleDefinition.java:
##########
@@ -57,29 +57,60 @@ public class ThrottleDefinition extends ExpressionNode
implements ExecutorServic
@XmlAttribute
@Metadata(label = "advanced", javaType = "java.lang.Boolean")
private String rejectExecution;
+ @XmlAttribute
+ @Metadata(defaultValue = "1000", javaType = "java.time.Duration")
+ private String timePeriodMillis;
+
+ @XmlAttribute
+ @Metadata(label = "advanced", javaType =
"org.apache.camel.model.ThrottlingMode", defaultValue = "TotalRequests",
Review Comment:
Before or after `correlationExpression`. It seems like we enforce a
particular order via `@XmlType`:
`@XmlType(propOrder = { "expression", "correlationExpression" })`
I'm wondering if I should do something like:
`@XmlType(propOrder = { "expression", "mode", "correlationExpression" })`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
