jamesnetherton commented on code in PR #5719:
URL: https://github.com/apache/camel-quarkus/pull/5719#discussion_r1481527863
##########
integration-tests/infinispan/src/test/java/org/apache/camel/quarkus/component/infinispan/InfinispanServerTestResource.java:
##########
@@ -16,20 +16,21 @@
*/
package org.apache.camel.quarkus.component.infinispan;
-import java.util.Map;
+import io.quarkus.test.common.QuarkusTestResourceLifecycleManager;
-import
org.apache.camel.quarkus.component.infinispan.common.InfinispanCommonServerTestResource;
+import java.util.HashMap;
+import java.util.Map;
-public class InfinispanServerTestResource extends
InfinispanCommonServerTestResource {
+public class InfinispanServerTestResource implements
QuarkusTestResourceLifecycleManager {
@Override
public Map<String, String> start() {
- Map<String, String> config = super.start();
+ Map<String, String> config = new HashMap<>();
config.put("camel.component.infinispan.autowired-enabled", "false");
- config.put("camel.component.infinispan.hosts", getServerList());
- config.put("camel.component.infinispan.username", USER);
- config.put("camel.component.infinispan.password", PASS);
+ config.put("camel.component.infinispan.hosts", "localhost:31222");
Review Comment:
We need to avoid hard coding `localhost`. It wont work if the tests run
against a remote Docker host. You can try getting the actual host value from
`DockerClientFactory.instance().dockerHostIpAddress()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
