JiriOndrusek commented on code in PR #5730:
URL: https://github.com/apache/camel-quarkus/pull/5730#discussion_r1481494346


##########
poms/bom-test/pom.xml:
##########
@@ -178,6 +178,17 @@
                 
<artifactId>camel-quarkus-integration-tests-support-custom-type-converter</artifactId>
                 <version>${camel-quarkus.version}</version>
             </dependency>
+            <dependency>
+                <groupId>org.apache.camel.quarkus</groupId>
+                
<artifactId>camel-quarkus-integration-tests-support-splunk</artifactId>
+                <version>${camel-quarkus.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.camel.quarkus</groupId>
+                
<artifactId>camel-quarkus-integration-tests-support-splunk</artifactId>
+                <version>${camel-quarkus.version}</version>
+                <type>test-jar</type>

Review Comment:
   It's unfortunate that just because of the constants, the dependency has to 
be added for the second time with the test scope. I think that overall this it 
is a nicer solution then having redefine the constants in the runtime for the 
second time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to