davsclaus commented on code in PR #12985:
URL: https://github.com/apache/camel/pull/12985#discussion_r1477063321
##########
core/pom.xml:
##########
@@ -59,6 +59,7 @@
<module>camel-cloud</module>
<module>camel-health</module>
<module>camel-console</module>
+ <module>camel-jolokia</module>
Review Comment:
jolokia should not be a core module, move this under components
##########
core/camel-jolokia/src/main/java/org/apache/camel/impl/jolokia/DefaultJolokiaHttpRequestHandlerFactory.java:
##########
@@ -36,17 +37,21 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-public class JolokiaHttpRequestHandlerSupport extends ServiceSupport
implements StaticService {
+/**
+ * Default {@link org.apache.camel.console.DevConsoleRegistry}.
+ */
+@DevConsole("jolokia")
Review Comment:
This is wrong. @DevConsole is only for camel-console type of consoles.
You need to come up with another annotation such as JdkFactory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
