orpiske commented on code in PR #12966:
URL: https://github.com/apache/camel/pull/12966#discussion_r1475782422


##########
pom.xml:
##########
@@ -915,5 +925,37 @@
                 </plugins>
             </build>
         </profile>
+        <profile>
+            <id>integration-test</id>
+            <!-- This profile can be used to run integration tests all by 
themselves without running the unit tests. -->
+            <!-- Use the command "mvn verify -Pintegration-test 
-Dquickly=true" to run the integration tests. -->
+            <build>
+                <plugins>
+                    <plugin>
+                        <groupId>org.apache.maven.plugins</groupId>
+                        <artifactId>maven-failsafe-plugin</artifactId>
+                        <version>${maven-failsafe-plugin-version}</version>
+                        <executions>
+                            <execution>
+                                <goals>
+                                    <goal>integration-test</goal>
+                                    <goal>verify</goal>
+                                </goals>
+                            </execution>
+                        </executions>
+                        <configuration>
+                            <skipITs>false</skipITs>
+                            <includes>
+                                <include>**/*IT.java</include>
+                                <include>**/*IntegrationTest.java</include>
+                            </includes>
+                            <excludes>
+                                <exclude>**/*Test.java</exclude>
+                            </excludes>
+                        </configuration>
+                    </plugin>
+                </plugins>
+            </build>
+        </profile>

Review Comment:
   I am truly sorry for having missed this, but I would us to avoid piling up 
the build with profiles that are very rarely used (by ourselves or by our CI or 
by the automation that we have). 
   
   We (myself included) spent a lot of time cleaning up a several profiles that 
existed on Camel 3 but we never used and complicated the build.
   
   For profiles, the less and simpler, the better. And this is specially true 
now that we have to tweak the build so it works flawlessly in different 
architectures (x86, aarch64, s390x, ppc6le).
   
   Lastly, the configuration part is not necessary because [failsafe already 
does (most of) this by 
default](https://maven.apache.org/surefire/maven-failsafe-plugin/examples/inclusion-exclusion.html).
 There are, indeed, some test cases that are (incorrectly) named 
`*IntegrationTest.java` (in `camel-google` and in `camel-salesforce`), but the 
proper fix here is to rename them to `*IT.java` as we did in the past. 
   
   @davsclaus @oscerd wdyt?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to