(camel) 02/03: (chores) camel-jms: minor code cleanups

[orpiske]

This is an automated email from the ASF dual-hosted git repository.

orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git

commit 3084fa4c86bff0d9879125aadd030a8529f17955
Author: Otavio R. Piske <angusyo...@gmail.com>
AuthorDate: Sat Jan 27 20:22:22 2024 +0100

    (chores) camel-jms: minor code cleanups
    
    - removed unused throws declaration
    - use isEmpty
    - use final fields when possible
    - reduced unnecessary field visibility
    
    Signed-off-by: Otavio R. Piske <angusyo...@gmail.com>
---
 .../main/java/org/apache/camel/component/jms/JmsConfiguration.java    | 4 ++--
 .../main/java/org/apache/camel/component/jms/JmsSendDynamicAware.java | 2 +-
 .../java/org/apache/camel/component/jms/reply/QueueReplyManager.java  | 3 +--
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git 
a/components/camel-jms/src/main/java/org/apache/camel/component/jms/JmsConfiguration.java
 
b/components/camel-jms/src/main/java/org/apache/camel/component/jms/JmsConfiguration.java
index 74e27a5b011..433e386bc6e 100644
--- 
a/components/camel-jms/src/main/java/org/apache/camel/component/jms/JmsConfiguration.java
+++ 
b/components/camel-jms/src/main/java/org/apache/camel/component/jms/JmsConfiguration.java
@@ -557,7 +557,7 @@ public class JmsConfiguration implements Cloneable {
     }
 
     public static class CamelJmsTemplate extends JmsTemplate {
-        private JmsConfiguration config;
+        private final JmsConfiguration config;
 
         public CamelJmsTemplate(JmsConfiguration config, ConnectionFactory 
connectionFactory) {
             super(connectionFactory);
@@ -1621,7 +1621,7 @@ public class JmsConfiguration implements Cloneable {
             }
         }
 
-        if (endpoint.getSelector() != null && endpoint.getSelector().length() 
!= 0) {
+        if (endpoint.getSelector() != null && 
!endpoint.getSelector().isEmpty()) {
             container.setMessageSelector(endpoint.getSelector());
         }
 
diff --git 
a/components/camel-jms/src/main/java/org/apache/camel/component/jms/JmsSendDynamicAware.java
 
b/components/camel-jms/src/main/java/org/apache/camel/component/jms/JmsSendDynamicAware.java
index d5877c83aa9..4e7aa1b2f4a 100644
--- 
a/components/camel-jms/src/main/java/org/apache/camel/component/jms/JmsSendDynamicAware.java
+++ 
b/components/camel-jms/src/main/java/org/apache/camel/component/jms/JmsSendDynamicAware.java
@@ -90,7 +90,7 @@ public class JmsSendDynamicAware extends ServiceSupport 
implements SendDynamicAw
         final String destinationName = parseDestinationName(entry.getUri());
         return new Processor() {
             @Override
-            public void process(Exchange exchange) throws Exception {
+            public void process(Exchange exchange) {
                 
exchange.getMessage().setHeader(JmsConstants.JMS_DESTINATION_NAME, 
destinationName);
             }
         };
diff --git 
a/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/QueueReplyManager.java
 
b/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/QueueReplyManager.java
index dda1293838f..c0697cf329d 100644
--- 
a/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/QueueReplyManager.java
+++ 
b/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/QueueReplyManager.java
@@ -41,7 +41,6 @@ import 
org.springframework.jms.support.destination.DestinationResolver;
 public class QueueReplyManager extends ReplyManagerSupport {
 
     private String replyToSelectorValue;
-    private MessageSelectorCreator dynamicMessageSelector;
 
     public QueueReplyManager(CamelContext camelContext) {
         super(camelContext);
@@ -238,7 +237,7 @@ public class QueueReplyManager extends ReplyManagerSupport {
                         endpoint.getReplyTo(), fixedMessageSelector, answer);
             } else {
                 // use a dynamic message selector which will select the 
message we want to receive as reply
-                dynamicMessageSelector = new 
MessageSelectorCreator(correlation);
+                MessageSelectorCreator dynamicMessageSelector = new 
MessageSelectorCreator(correlation);
                 answer = new SharedQueueMessageListenerContainer(endpoint, 
dynamicMessageSelector);
                 log.debug("Using shared queue: {} with dynamic message 
selector as reply listener: {}", endpoint.getReplyTo(),
                         answer);