christophd commented on code in PR #5086:
URL: https://github.com/apache/camel-k/pull/5086#discussion_r1461724333


##########
pkg/trait/camel.go:
##########
@@ -276,5 +278,5 @@ func determineRuntimeVersion(e *Environment) string {
        if e.Platform != nil && e.Platform.Status.Build.RuntimeVersion != "" {
                return e.Platform.Status.Build.RuntimeVersion
        }
-       return ""

Review Comment:
   `determineRuntimeVersion()` now returns an error for this case. I think it 
is more clear this way



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to