apupier commented on code in PR #12625:
URL: https://github.com/apache/camel/pull/12625#discussion_r1439481205
##########
components/camel-netty/src/test/java/org/apache/camel/component/netty/NettyTCPSyncUDSTest.java:
##########
@@ -19,16 +19,14 @@
import org.apache.camel.Exchange;
import org.apache.camel.Processor;
import org.apache.camel.builder.RouteBuilder;
-import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import static org.junit.jupiter.api.Assertions.assertEquals;
/**
- * Add {@code <classifier>linux-x86_64</classifier>} to
io.netty:netty-transport-native-epoll dependency to make this
- * test work
+ *
+ * @see <a href="https://netty.io/wiki/native-transports.html";>about netty
native transport</a>
*/
-@Disabled("Requires native library to load, can be run manually")
Review Comment:
For the note, I was thinking to provide a mention that `native transport`
is supported on Linux with epoll and Mac with kqueue. Maybe on the
`unixDomainSocketPath`
https://github.com/apache/camel/blob/0fb44f713f4eedb450970fe4b40a59c2cb2ab6dc/components/camel-netty/src/main/java/org/apache/camel/component/netty/NettyServerBootstrapConfiguration.java#L582
and if I understand well that the end-user must add some specific classifier
on Mac to make it working (is it right?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
