gansheer commented on code in PR #4914: URL: https://github.com/apache/camel-k/pull/4914#discussion_r1423956152
########## config/rbac/kustomization.yaml: ########## @@ -23,23 +23,22 @@ kind: Kustomization resources: - user-cluster-role.yaml -- operator-role-events.yaml -- operator-role-knative.yaml -- operator-role.yaml -- operator-role-keda.yaml -- operator-role-leases.yaml -- operator-role-podmonitors.yaml -- operator-role-strimzi.yaml -- operator-role-binding-events.yaml -- operator-role-binding-keda.yaml -- operator-role-binding-knative.yaml -- operator-role-binding-leases.yaml -- operator-role-binding-local-registry.yaml -- operator-role-binding-podmonitors.yaml -- operator-role-binding-strimzi.yaml -- operator-role-binding.yaml - operator-cluster-role-custom-resource-definitions.yaml - operator-cluster-role-binding-custom-resource-definitions.yaml - operator-cluster-role-addressable-resolver.yaml - operator-cluster-role-binding-addressable-resolver.yaml - operator-cluster-role-local-registry.yaml +- operator-role-binding-local-registry.yaml + + +transformers: Review Comment: Actually this is a fix. This RoleBinding should not have been transformed in a ClusterRoleBinding in the first place as it is supposed to only give access to a configmap in the "kube-public" namespace. The current documentation only reference the "high-level" kustomization files (or the install script https://camel.apache.org/camel-k/2.1.x/installation/advanced/kustomize.html), but you are right I will update [this part](https://camel.apache.org/camel-k/2.1.x/installation/installation.html#kustomize) to add some explanation. In any case a lot of documentation for specific cases are lacking in favor of the script usage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
