zregvart commented on PR #12146: URL: https://github.com/apache/camel/pull/12146#issuecomment-1824042120
> * I thought the :eips: in the xrefs was required. But maybe not in the nav file itself? xref can contain only the name of the file if that file resides in the [same module and component version](https://docs.antora.org/antora/latest/page/page-links/#pages), and in this case `nav.adoc` and other `.adoc` are in the same `eips` module. > * Not being a js expert, I'm not sure, but it looks to me like your change will add a createNav task both with and without a filter for all the sources which have both a json and an asciidoc with source property, and they all do except eips. Yeah, I've added an [explicit](https://github.com/apache/camel/pull/12146/files#diff-a0e44ac534103410f3aa0fdacfc392140e8673f3454e0e842c3e6c82fb108810R451) `!asciidoc.source`, though Gulp maintains unique names of tasks, so the `nav:asciidoc:eips` task in the [`json` branch](https://github.com/apache/camel/pull/12146/files#diff-a0e44ac534103410f3aa0fdacfc392140e8673f3454e0e842c3e6c82fb108810R445) should override the task in the [`asciidoc`](https://github.com/apache/camel/pull/12146/files#diff-a0e44ac534103410f3aa0fdacfc392140e8673f3454e0e842c3e6c82fb108810R417) branch. I think having the explicit condition there helps though, at least when trying to grok the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
