mvolf commented on code in PR #992: URL: https://github.com/apache/camel-karavan/pull/992#discussion_r1400556630
########## karavan-web/karavan-app/src/main/java/org/apache/camel/karavan/service/ProjectService.java: ########## @@ -187,34 +187,38 @@ public Project save(Project project) throws Exception { } public Project copy(String sourceProjectId, Project project) throws Exception { + boolean isNew = infinispanService.getProject(project.getProjectId()) == null; Project sourceProject = infinispanService.getProject(sourceProjectId); + // Save project infinispanService.saveProject(project); Review Comment: @mgubaidullin This was confusing for me as well, but I kept the same implementation that's used for the create project (ProjectService.save method). For create project action, if existing project-id is sent everything is skipped except that step. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org