orpiske commented on code in PR #11934:
URL: https://github.com/apache/camel/pull/11934#discussion_r1386117008
##########
core/camel-core/src/test/java/org/apache/camel/component/file/FileConsumerFailureHandledTest.java:
##########
@@ -57,7 +57,7 @@ public void testLondon() throws Exception {
mock.expectedBodiesReceived("London");
template.sendBodyAndHeader(fileUri(), "London", Exchange.FILE_NAME,
"london.txt");
- mock.assertIsSatisfied(1000);
+ mock.assertIsSatisfied(3000);
Review Comment:
Why the timeout increase?
##########
core/camel-core/src/test/java/org/apache/camel/component/file/FileConsumerFailureHandledTest.java:
##########
@@ -87,7 +87,7 @@ public void testMadrid() throws Exception {
mock.expectedBodiesReceived("Madrid");
template.sendBodyAndHeader(fileUri(), "Madrid", Exchange.FILE_NAME,
"madrid.txt");
- mock.assertIsSatisfied(1000);
+ mock.assertIsSatisfied(3000);
Review Comment:
Same note about the timeout increase.
##########
core/camel-core/src/test/java/org/apache/camel/component/file/FileConsumerFailureHandledTest.java:
##########
@@ -72,7 +72,7 @@ public void testDublin() throws Exception {
mock.expectedBodiesReceived("Dublin");
template.sendBodyAndHeader(fileUri(), "Dublin", Exchange.FILE_NAME,
"dublin.txt");
- mock.assertIsSatisfied(1000);
+ mock.assertIsSatisfied(3000);
Review Comment:
Same note about the timeout increase.
##########
core/camel-core/src/test/java/org/apache/camel/TestSupport.java:
##########
@@ -445,43 +422,6 @@ public static Channel unwrapChannel(Processor processor) {
}
}
- /**
- * Recursively delete a directory, useful to zapping test data
- *
- * @param file the directory to be deleted
- */
- public static void deleteDirectory(String file) {
- deleteDirectory(new File(file));
- }
-
- /**
- * Recursively delete a directory, useful to zapping test data
- *
- * @param file the directory to be deleted
- */
- public static void deleteDirectory(File file) {
- if (file.isDirectory()) {
- File[] files = file.listFiles();
- if (files != null) {
- for (File child : files) {
- deleteDirectory(child);
- }
- }
- }
-
- file.delete();
- }
-
- /**
- * create the directory
- *
- * @param file the directory to be created
- */
- public static void createDirectory(String file) {
- File dir = new File(file);
- dir.mkdirs();
- }
-
Review Comment:
We probably need to document the removal of these methods on the upgrade
documentation. They may be used elsewhere / by users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
