brunoriemenschneider commented on code in PR #11930:
URL: https://github.com/apache/camel/pull/11930#discussion_r1384939826


##########
components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppConfiguration.java:
##########
@@ -733,6 +735,26 @@ public void setSingleDLR(boolean singleDLR) {
         this.singleDLR = singleDLR;
     }
 
+    public String getInterfaceVersion() {
+        return interfaceVersion;
+    }
+
+    /**
+     * Defines the interface version to be used in the binding request with 
the SMSC. The following values are allowed,
+     * as defined in the SMPP protocol:
+     * <ul>

Review Comment:
   I have used the syntax that a lot of the other configuration fields have 
used (look at this file and scroll up for a few cases). I can see though that 
they are not really useful in the docs 
(https://camel.apache.org/components/4.0.x/smpp-component.html). Will remove.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to