squakez commented on code in PR #4812:
URL: https://github.com/apache/camel-k/pull/4812#discussion_r1354602124
##########
pkg/trait/camel.go:
##########
@@ -238,8 +239,9 @@ func (t *camelTrait) computeConfigMaps(e *Environment)
[]ctrl.Object {
)
}
- for i, s := range sources {
- if s.ContentRef != "" || e.isEmbedded(s) {
+ i := 0
Review Comment:
the change is not the index itself. The problem is that if we let the
variable as implicit part of the loop, it increments also when we skip the
source, ie, is embedded, kamelet, etc. But we only want to increment when it is
really processed, reason why we need to make it explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
