orpiske commented on code in PR #11225:
URL: https://github.com/apache/camel/pull/11225#discussion_r1308451384
##########
components/camel-vertx/camel-vertx-common/src/generated/java/org/apache/camel/component/vertx/common/CamelVertxCommonBulkConverterLoader.java:
##########
@@ -165,6 +167,41 @@ private Object doConvertTo(Class<?> from, Class<?> to,
Exchange exchange, Object
return null;
}
+ private void doRegistration(TypeConverterRegistry registry) {
+ registry.addConverter(new
TypeConvertible<>(io.vertx.core.buffer.Buffer.class, byte[].class), this);
+ registry.addConverter(new
TypeConvertible<>(io.vertx.core.json.JsonArray.class, byte[].class), this);
+ registry.addConverter(new
TypeConvertible<>(io.vertx.core.json.JsonObject.class, byte[].class), this);
+ registry.addConverter(new TypeConvertible<>(byte[].class,
io.vertx.core.buffer.Buffer.class), this);
+ registry.addConverter(new
TypeConvertible<>(io.netty.buffer.ByteBuf.class,
io.vertx.core.buffer.Buffer.class), this);
+ registry.addConverter(new
TypeConvertible<>(io.vertx.core.json.JsonArray.class,
io.vertx.core.buffer.Buffer.class), this);
+ registry.addConverter(new
TypeConvertible<>(io.vertx.core.json.JsonObject.class,
io.vertx.core.buffer.Buffer.class), this);
+ registry.addConverter(new TypeConvertible<>(java.io.InputStream.class,
io.vertx.core.buffer.Buffer.class), this);
+ registry.addConverter(new TypeConvertible<>(java.lang.String.class,
io.vertx.core.buffer.Buffer.class), this);
+ registry.addConverter(new TypeConvertible<>(byte[].class,
io.vertx.core.json.JsonArray.class), this);
+ registry.addConverter(new
TypeConvertible<>(io.netty.buffer.ByteBuf.class,
io.vertx.core.json.JsonArray.class), this);
+ registry.addConverter(new
TypeConvertible<>(io.vertx.core.buffer.Buffer.class,
io.vertx.core.json.JsonArray.class), this);
+ registry.addConverter(new TypeConvertible<>(java.io.InputStream.class,
io.vertx.core.json.JsonArray.class), this);
+ registry.addConverter(new TypeConvertible<>(java.lang.String.class,
io.vertx.core.json.JsonArray.class), this);
+ registry.addConverter(new TypeConvertible<>(java.util.List.class,
io.vertx.core.json.JsonArray.class), this);
+ registry.addConverter(new TypeConvertible<>(byte[].class,
io.vertx.core.json.JsonObject.class), this);
+ registry.addConverter(new
TypeConvertible<>(io.netty.buffer.ByteBuf.class,
io.vertx.core.json.JsonObject.class), this);
+ registry.addConverter(new
TypeConvertible<>(io.vertx.core.buffer.Buffer.class,
io.vertx.core.json.JsonObject.class), this);
+ registry.addConverter(new TypeConvertible<>(java.io.InputStream.class,
io.vertx.core.json.JsonObject.class), this);
+ registry.addConverter(new TypeConvertible<>(java.lang.String.class,
io.vertx.core.json.JsonObject.class), this);
+ registry.addConverter(new TypeConvertible<>(java.util.Map.class,
io.vertx.core.json.JsonObject.class), this);
+ registry.addConverter(new
TypeConvertible<>(io.vertx.core.buffer.Buffer.class,
java.io.InputStream.class), this);
+ registry.addConverter(new
TypeConvertible<>(io.vertx.core.json.JsonArray.class,
java.io.InputStream.class), this);
+ registry.addConverter(new
TypeConvertible<>(io.vertx.core.json.JsonObject.class,
java.io.InputStream.class), this);
+ registry.addConverter(new
TypeConvertible<>(io.vertx.core.buffer.Buffer.class, java.lang.String.class),
this);
+ registry.addConverter(new
TypeConvertible<>(io.vertx.core.json.JsonArray.class, java.lang.String.class),
this);
+ registry.addConverter(new
TypeConvertible<>(io.vertx.core.json.JsonObject.class, java.lang.String.class),
this);
+ registry.addConverter(new
TypeConvertible<>(io.vertx.core.json.JsonArray.class, java.util.List.class),
this);
+ registry.addConverter(new
TypeConvertible<>(io.vertx.core.json.JsonObject.class, java.util.Map.class),
this);
+ registry.addConverter(new
TypeConvertible<>(io.vertx.core.buffer.Buffer.class,
org.apache.camel.StreamCache.class), this);
+
+
+ }
+
public TypeConverter lookup(Class<?> to, Class<?> from) {
Review Comment:
There's still a lot of code relying on the lookup and it seems that we have
some features that require the lookup behavior (i.e.: fallback promotion [
seems to be used for beans], CXF converter, etc).
For now, I am being conservative and I am aiming to be as
compliant/compatible with the old code as possible to avoid introducing more
changes than I can handle.
So, I am thinking about leaving this one for this first patch. Then slowly
start to replacing usages of the lookup (or clean it up - at least).
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
