gansheer commented on code in PR #4680:
URL: https://github.com/apache/camel-k/pull/4680#discussion_r1302641831
##########
pkg/util/maven/maven_command.go:
##########
@@ -142,7 +142,12 @@ func (c *Command) Do(ctx context.Context) error {
Log.WithValues("MAVEN_OPTS", mavenOptions).Infof("executing: %s",
strings.Join(cmd.Args, " "))
- return util.RunAndLog(ctx, cmd, mavenLogHandler, mavenLogHandler)
+ // generate maven file
+ if err := generateMavenContext(c.context.Path, args); err != nil {
Review Comment:
It would be better, but I would like to dedicate another issue to this part
as it needs a big refactoring in a sensitive part of the build task. It would
also be an occasion to see if we can separate the maven code dedicated to
commands execution from the project generation code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
