ppalaga commented on code in PR #5166:
URL: https://github.com/apache/camel-quarkus/pull/5166#discussion_r1291508991
##########
tooling/scripts/sanity-checks.groovy:
##########
@@ -68,10 +68,11 @@ int compareVersion(String a, String b) {
List verB = b.tokenize('.')
def commonIndices = Math.min(verA.size(), verB.size())
+ def versionRegex = ~/\-.*/
for (int i = 0; i < commonIndices; ++i) {
def numA = verA[i].toInteger()
- def numB = verB[i].toInteger()
+ def numB = (verB[i] - versionRegex).toInteger()
Review Comment:
Yeah, I think that would be safer for any future reuse of `compareVersion()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
