squakez commented on code in PR #4659:
URL: https://github.com/apache/camel-k/pull/4659#discussion_r1289822775
##########
e2e/common/config/kamelet_config_test.go:
##########
@@ -89,6 +90,25 @@ func TestKameletImplicitConfig(t *testing.T) {
Expect(DeleteSecret(ns, secretName)).To(Succeed())
})
+ t.Run("run test default config using mounted configmap", func(t
*testing.T) {
+ name :=
"my-own-timer-source-default-config-mounted-configmaps"
+ cmName := "my-mounted-default-secret"
+
+ var cmData = make(map[string]string)
+ cmData["camel.kamelet.my-own-timer-source.message"] =
"very top mounted configmap message"
+ Expect(CreatePlainTextConfigmap(ns, cmName,
cmData)).To(Succeed())
+
+ Expect(KamelRunWithID(operatorID, ns,
"files/TimerKameletIntegrationConfiguration.java",
+ "-p",
"camel.kamelet.my-own-timer-source.message='Default message'",
Review Comment:
Okey, that was my confusion. No I think that for the sake of this PR we
should remove any ambiguity. I'd say we already cover the precedence check in
some other test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
