stefanhuber commented on issue #836: URL: https://github.com/apache/camel-karavan/issues/836#issuecomment-1670299405
Ok is there already a branch for that? If you define how, I might be able to help you with some of the components. Firstly, thank you for providing such a great tool. Some first thoughts/obvservations, which I made when going through the code base: - It might make sense to create a folder for each component and also add css (instead of one big karavan.css). - Some components are quite big (e.g, [RestDesigner](https://github.com/apache/camel-karavan/blob/main/karavan-designer/src/designer/rest/RestDesigner.tsx)), it might be possible to split them into smaller ones - Use 2 spaces for indentation might help ([example](https://github.com/apache/camel-karavan/blob/f6f77ea88b364b6ba7e479327964e1092b4804fc/karavan-designer/src/designer/beans/BeansDesigner.tsx#L130)), it is generally used with javascript - Adding testing to the component folder directly - Starting the development server with `npm start` takes a long time, vite would improve this drastically - It might makes sense to use storybook for developing components in isolation - Why use react layout components, if the same is possible with css flexbox, just with less code and better performance? ([example](https://github.com/apache/camel-karavan/blob/f6f77ea88b364b6ba7e479327964e1092b4804fc/karavan-designer/src/DesignerPage.tsx#L111)) - One could create a custom hook in react instead of an additional library (`lodash.debounce`) for debounding ([example](https://dev.to/rajeshroyal/how-to-make-a-custom-debounce-hook-in-react-js-4gcc)) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
