simon-ras opened a new pull request, #10847: URL: https://github.com/apache/camel/pull/10847
The SQS consumer is a polling consumer, and thus we can use `ScheduledPollConsumerHealthCheck` where we observe the last poll rather than making a new operation against SQS. Previously `listQueues` was called, which is a different API than what the consumer actually uses (`receiveMessage`). The `Sqs2ConsumerHealthCheck` used to check if configured region existed in the metadata of the client. That logic was copied over from the old `Sqs2ComponentVerifierExtension`. It is removed from this implementation as the call to `poll` will yield in the same outcome in case an incorrect Region is defined in the configuration. In this case, a failed poll, causing the health check to be DOWN. <!-- - Write a pull request description that is detailed enough to understand what the pull request does, how, and why. --> # Target - [ ] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch) # Tracking - [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). <!-- # *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes. --> # Apache Camel coding standards and style - [ ] I checked that each commit in the pull request has a meaningful subject line and body. <!-- If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue. --> - [ ] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes <!-- You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`. You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
