orpiske commented on PR #10512: URL: https://github.com/apache/camel/pull/10512#issuecomment-1609303735
@davsclaus adding to the ones above cause side effects. This one is OK because the `callback.done(true);` is supposed to run regardless of a exception being thrown or not. On the one above, it's only called when catching an exception, so adding to the finally would also cause it to run when it shouldn't. I'm leaving as is for now - I can investigate later if you want. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
