johbossle commented on PR #10498: URL: https://github.com/apache/camel/pull/10498#issuecomment-1608868149
@zhfeng For me, there were two reasons to allow the override of LRARoutes: - keep it in analogy with the creation process of LRAClient (I'm personally not a big fan of hard-coded constructor calls without possibility to influence anything. It makes it harder to test, less open for other use-cases, ...) - Get at least a a possibility to influence the verification of the requests. Nevertheless, I do understand the risk of missing the routes and the importance of those. But if you are overriding, you hopefully know what you are doing. You could also manipulate the CamelContext and remove the routes etc. To continue, I do see now the following possibilities: - In general, we do not want to allow to override the LRASagaRoutes creation - We simply do it as proposed right now - We split this aspect into an extra PR and realize the topic here - maybe in consequence also with having a protected method for verifyRequest. What way should we follow? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
