JiriOndrusek commented on PR #4951: URL: https://github.com/apache/camel-quarkus/pull/4951#issuecomment-1580970664
> I am not sure if we want to be supporting `micrometer-registry-jmx` directly in this project. Otherwise, we have to maintain the dependencies, tests and docs explaining how to configure it. > > Support for the different Micrometer registry implementations lives here: > > https://github.com/quarkiverse/quarkus-micrometer-registry/ > > So maybe a better way would be to add `io.quarkiverse.micrometer.registry:quarkus-micrometer-registry-jmx` only to the test BOM. And just replace the table in our [usage docs](https://camel.apache.org/camel-quarkus/next/reference/extensions/micrometer.html#extensions-micrometer-usage) with a link to [here](https://quarkiverse.github.io/quarkiverse-docs/quarkus-micrometer-registry/dev/index.html) . > > It's a bit of an open question whether we even need to test the JMX bits at all, given it's already tested elsewhere. > > WDYT @ppalaga? The dependency is changed and moved. Table in the doc is replaced but I had to keep onel dependency for prometheus which is not part of the quarkiverse doc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
