orpiske commented on PR #10234:
URL: https://github.com/apache/camel/pull/10234#issuecomment-1567778158

   > @orpiske as you are the code owner of the test-infra components, what do 
you think of this approach?
   
   That's an interesting approach and I am OK with it. 
   
   I am curious about something, though: have you tried implementing 
JUnit-based singleton services for Elasticsearch? This approach uses JUnit's 
[context extension 
store](https://github.com/apache/camel/blob/main/test-infra/camel-test-infra-common/src/test/java/org/apache/camel/test/infra/common/services/SingletonService.java#L40-L48)
 to retain the instance between test executions. 
   We [do that for 
Kafka](https://github.com/apache/camel/blob/main/test-infra/camel-test-infra-kafka/src/test/java/org/apache/camel/test/infra/kafka/services/KafkaServiceFactory.java#L25-L44)
 and it seems to improve the test times too (save for a few scenarios where we 
need to break stuff / or need broken stuff). 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to