avano commented on code in PR #4918:
URL: https://github.com/apache/camel-quarkus/pull/4918#discussion_r1203550939


##########
integration-tests/jms-ibmmq-client/src/test/java/org/apache/camel/quarkus/component/jms/ibmmq/it/IBMMQTest.java:
##########
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.jms.ibmmq.it;
+
+import java.lang.reflect.Method;
+
+import io.quarkus.test.common.QuarkusTestResource;
+import io.quarkus.test.junit.QuarkusTest;
+import io.restassured.RestAssured;
+import org.apache.camel.quarkus.messaging.jms.AbstractJmsMessagingTest;
+import org.apache.camel.quarkus.test.support.ibmmq.IBMMQDestinations;
+import org.apache.camel.quarkus.test.support.ibmmq.IBMMQTestResource;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.TestInfo;
+import org.junit.jupiter.api.TestInstance;
+import org.junit.jupiter.api.condition.EnabledIfSystemProperty;
+
+import static org.hamcrest.Matchers.is;
+import static org.hamcrest.Matchers.startsWith;
+
+@QuarkusTest
+@QuarkusTestResource(IBMMQTestResource.class)
+@EnabledIfSystemProperty(named = "ibm.mq.container.license", matches = 
"accept")
+@TestInstance(TestInstance.Lifecycle.PER_CLASS)
+public class IBMMQTest extends AbstractJmsMessagingTest {
+    IBMMQDestinations destinations;
+
+    /**
+     * IBM MQ needs to have the destinations created before you can use them.
+     * <p>
+     * This method is called after the routes start, so the routes will print 
a warning first that the destinations don't
+     * exist, only then they are
+     * created using this method
+     *
+     * @param test test
+     */
+    @BeforeAll
+    public void createDestinations(TestInfo test) {
+        for (Method method : test.getTestClass().get().getMethods()) {
+            destinations.createQueue(method.getName());
+            // Some tests use two queues
+            destinations.createQueue(method.getName() + "2");
+            destinations.createTopic(method.getName());
+        }
+
+        // Sleep for a while to allow the routes to reconnect
+        try {
+            Thread.sleep(5000L);

Review Comment:
   @ppalaga could you please elaborate? Wouldn't that require maintaining a 
list of destination names that should be created inside `IBMMQTestResource` 
when a new test is added to, for example, 
[AbstractMessagingTest](https://github.com/avano/camel-quarkus/blob/ibm-mq/integration-tests/messaging/common/src/test/java/org/apache/camel/quarkus/component/messaging/it/AbstractMessagingTest.java)?
   
   Or did you mean to re-use one queue/topic for all tests?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to