Instead of Collections.EMPTY_XYZ, better make use of the Collections.emptyXYZ() 
utilities having proper generic signature so that using 
@SuppressWarnings("unchecked") becomes obsolete. Also fixed one tiny CS 
violation.

Project: http://git-wip-us.apache.org/repos/asf/camel/repo
Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/66ec8cf9
Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/66ec8cf9
Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/66ec8cf9

Branch: refs/heads/master
Commit: 66ec8cf994188eb5d1c03dcd2ac0420197299a33
Parents: c13f7c8
Author: Babak Vahdat <bvah...@apache.org>
Authored: Sun Nov 24 12:27:55 2013 +0100
Committer: Babak Vahdat <bvah...@apache.org>
Committed: Sun Nov 24 12:27:55 2013 +0100

----------------------------------------------------------------------
 .../apache/camel/impl/DefaultCamelContext.java  |    3 +-
 .../util/DumpModelAsXmlTransformRouteTest.java  |    8 +-
 .../camel/component/http4/NoopCookieStore.java  |    3 +-
 .../component/xmlsecurity/XmlSignatureTest.java | 2207 +++++++++---------
 .../java/org/apache/camel/maven/RunMojo.java    |    4 +-
 .../org/apache/camel/guice/maven/RunMojo.java   |    4 +-
 6 files changed, 1113 insertions(+), 1116 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/camel/blob/66ec8cf9/camel-core/src/main/java/org/apache/camel/impl/DefaultCamelContext.java
----------------------------------------------------------------------
diff --git 
a/camel-core/src/main/java/org/apache/camel/impl/DefaultCamelContext.java 
b/camel-core/src/main/java/org/apache/camel/impl/DefaultCamelContext.java
index bf90c7b..b9f8b25 100644
--- a/camel-core/src/main/java/org/apache/camel/impl/DefaultCamelContext.java
+++ b/camel-core/src/main/java/org/apache/camel/impl/DefaultCamelContext.java
@@ -636,11 +636,10 @@ public class DefaultCamelContext extends ServiceSupport 
implements ModelCamelCon
         return routeStartupOrder;
     }
 
-    @SuppressWarnings("unchecked")
     public List<Route> getRoutes() {
         // lets return a copy of the collection as objects are removed later 
when services are stopped
         if (routes.isEmpty()) {
-            return Collections.EMPTY_LIST;
+            return Collections.emptyList();
         } else {
             return new ArrayList<Route>(routes);
         }

http://git-wip-us.apache.org/repos/asf/camel/blob/66ec8cf9/camel-core/src/test/java/org/apache/camel/util/DumpModelAsXmlTransformRouteTest.java
----------------------------------------------------------------------
diff --git 
a/camel-core/src/test/java/org/apache/camel/util/DumpModelAsXmlTransformRouteTest.java
 
b/camel-core/src/test/java/org/apache/camel/util/DumpModelAsXmlTransformRouteTest.java
index e58d68d..3c0851c 100644
--- 
a/camel-core/src/test/java/org/apache/camel/util/DumpModelAsXmlTransformRouteTest.java
+++ 
b/camel-core/src/test/java/org/apache/camel/util/DumpModelAsXmlTransformRouteTest.java
@@ -16,14 +16,14 @@
  */
 package org.apache.camel.util;
 
+import org.w3c.dom.Document;
+import org.w3c.dom.Element;
+import org.w3c.dom.NodeList;
+
 import org.apache.camel.ContextTestSupport;
 import org.apache.camel.builder.RouteBuilder;
 import org.apache.camel.converter.jaxp.XmlConverter;
 import org.apache.camel.model.ModelHelper;
-import org.w3c.dom.Document;
-import org.w3c.dom.Element;
-import org.w3c.dom.Node;
-import org.w3c.dom.NodeList;
 
 /**
  *

http://git-wip-us.apache.org/repos/asf/camel/blob/66ec8cf9/components/camel-http4/src/main/java/org/apache/camel/component/http4/NoopCookieStore.java
----------------------------------------------------------------------
diff --git 
a/components/camel-http4/src/main/java/org/apache/camel/component/http4/NoopCookieStore.java
 
b/components/camel-http4/src/main/java/org/apache/camel/component/http4/NoopCookieStore.java
index 85221d9..45d07f2 100644
--- 
a/components/camel-http4/src/main/java/org/apache/camel/component/http4/NoopCookieStore.java
+++ 
b/components/camel-http4/src/main/java/org/apache/camel/component/http4/NoopCookieStore.java
@@ -34,9 +34,8 @@ public class NoopCookieStore implements CookieStore {
     }
 
     @Override
-    @SuppressWarnings("unchecked")
     public List<Cookie> getCookies() {
-        return Collections.EMPTY_LIST;
+        return Collections.emptyList();
     }
 
     @Override

Reply via email to