oscerd commented on code in PR #9983: URL: https://github.com/apache/camel/pull/9983#discussion_r1189487021
########## dsl/camel-jbang/camel-jbang-it/pom.xml: ########## @@ -0,0 +1,261 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.camel</groupId> + <artifactId>camel-jbang-parent</artifactId> + <version>4.0.0-SNAPSHOT</version> + <relativePath>../pom.xml</relativePath> + </parent> + + <artifactId>camel-jbang-it</artifactId> + <name>Camel :: JBang :: Integration tests</name> + <packaging>jar</packaging> + + <properties> + <maven.test.skip>true</maven.test.skip> + <awaitility.version>4.2.0</awaitility.version> Review Comment: I do think this should be from the parent pom and not defined here ########## dsl/camel-jbang/camel-jbang-it/pom.xml: ########## @@ -0,0 +1,261 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.camel</groupId> + <artifactId>camel-jbang-parent</artifactId> + <version>4.0.0-SNAPSHOT</version> + <relativePath>../pom.xml</relativePath> + </parent> + + <artifactId>camel-jbang-it</artifactId> + <name>Camel :: JBang :: Integration tests</name> + <packaging>jar</packaging> + + <properties> + <maven.test.skip>true</maven.test.skip> + <awaitility.version>4.2.0</awaitility.version> + <logback.version>1.4.7</logback.version> Review Comment: Same ########## dsl/camel-jbang/camel-jbang-it/pom.xml: ########## @@ -0,0 +1,261 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.camel</groupId> + <artifactId>camel-jbang-parent</artifactId> + <version>4.0.0-SNAPSHOT</version> + <relativePath>../pom.xml</relativePath> + </parent> + + <artifactId>camel-jbang-it</artifactId> + <name>Camel :: JBang :: Integration tests</name> + <packaging>jar</packaging> + + <properties> + <maven.test.skip>true</maven.test.skip> + <awaitility.version>4.2.0</awaitility.version> + <logback.version>1.4.7</logback.version> + <assertj.version>3.24.2</assertj.version> Review Comment: Same -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
