davsclaus commented on code in PR #9982: URL: https://github.com/apache/camel/pull/9982#discussion_r1183300670
########## core/camel-support/src/main/java/org/apache/camel/support/EnumArray.java: ########## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.camel.support; + +import java.util.Arrays; +import java.util.HashMap; +import java.util.Map; +import java.util.Objects; +import java.util.function.Function; + +/** + * This class provides an array-based structure used to store payloads associated with enums. This is + * used in the hot path of the core code to allow access to those payloads with constant time and low + * memory overhead. + * + * This data-structure is meant for internal usage of the Camel Core and is not meant for users. + * @param <T> + */ +public final class EnumArray<T extends Enum<?>> { + private final Object[] internalArray; + private final T[] values; + + /** + * Creates a new EnumArray with a fixed size determined by the length of values + * @param values the Enum values (as in Enum.values()) + */ + public EnumArray(T[] values) { + this.internalArray = new Object[values.length]; + this.values = values; + } + + /** + * Whether this arrau contains a payload (value) for the given entry + * @param entry the entry to check for + * @return true if there is a payload or false otherwise + */ + public boolean contains(T entry) { + Object payload = internalArray[entry.ordinal()]; + + return payload != null; + } + + /** + * Gets the payload for the given entry + * @param entry the entry to get the payload (must not be null) + * @return the payload or false otherwise + */ + public Object get(T entry) { + Objects.requireNonNull(entry, "The entry for a enum array cannot be null"); Review Comment: This just adds unnessasary overhead on a hot path - the old code did not need this check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
