dk2k commented on code in PR #9939:
URL: https://github.com/apache/camel/pull/9939#discussion_r1180779656
##########
components/camel-as2/camel-as2-component/src/test/java/org/apache/camel/component/as2/MendelsonCertLoader.java:
##########
@@ -0,0 +1,183 @@
+package org.apache.camel.component.as2;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.nio.charset.StandardCharsets;
+import java.security.KeyManagementException;
+import java.security.KeyStore;
+import java.security.KeyStoreException;
+import java.security.NoSuchAlgorithmException;
+import java.security.PrivateKey;
+import java.security.UnrecoverableKeyException;
+import java.security.cert.Certificate;
+import java.security.cert.CertificateException;
+import java.security.cert.CertificateFactory;
+import java.security.spec.InvalidKeySpecException;
+import java.util.ArrayList;
+import java.util.Base64;
+import java.util.List;
+
+import javax.net.ssl.SSLContext;
+
+import org.apache.commons.io.IOUtils;
+import org.apache.http.conn.ssl.TrustAllStrategy;
+import org.apache.http.ssl.SSLContexts;
+
+/**
+ * That's a utility class for preparing Mendelson-specific certificate chain,
private key, ssl context
+ */
+public class MendelsonCertLoader {
Review Comment:
I'm not sure that disabled by default test can be considered a dependency.
It's just good manners: showing a way a person can establish HTTPS AS2
connection to non-localhost server.
If Mendelson goes down, just remove two classes with Mendelson in the name,
the test/resource folder mendelson and the file test-server.properties. I will
be able to do that myself. No hurt feelings on my side then :)
I think dockerization of AS2 server is beyond the scope of the ticket
CAMEL-17946
Besides, what exactly are you going to dockerize? Camel AS2 server
component? Both Camel AS2 server and client can have issues which will allow
them to communicate, but not to other AS2-compliant server (what if the sources
of both client and server suffer from the same issue?). Another point: it's
important to test HTTPS connection to non-localhost server - test the new
HostnameVerifier field. Will docker allow that?
I'm not sure you have seen my latest commit with moving Mendelson connection
settings to a property file as per @davsclaus 's comment. Now a person needs to
turn on 2 "knobs" to connect to Mendelson:
- remove/comment @Disabled annotation
- explicitly set Mendelson hostname in the properties.
Please let me know if the latest commit mitigates or even eliminates your
concerns. If it dosen't, I will remove all Mendelson-related stuff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
