ppalaga commented on PR #4768:
URL: https://github.com/apache/camel-quarkus/pull/4768#issuecomment-1506925663

   Hm... the examples seem to be built from camel-quarkus-main branch where 
Java version is set to 17 in the POMs. It fails because this 2.13.x workflow 
uses Java 11 for building. 
   @jamesnetherton I wonder whether we should not replace `GITHUB_REF_NAME` 
with `GITHUB_BASE_REF` around here?
   
   ```
             EXAMPLES_BRANCH="camel-quarkus-main"
   
             if [[ ${GITHUB_REF_NAME} =~ [0-9]+.[0-9]+.x ]]; then
                 EXAMPLES_BRANCH=${GITHUB_REF_NAME}
             fi
   ```
   
   The 
[docs](https://docs.github.com/en/actions/learn-github-actions/variables) 
sounds like `GITHUB_REF_NAME` is the feature branch. But `GITHUB_BASE_REF` 
would work only for PR builds. Are we actually also building on merge? If so, 
then we somehow need to alternate between `GITHUB_REF_NAME` and 
`GITHUB_BASE_REF`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to