CAMEL-6851: Fixed allowing underscore in trigger name in quartz endpoint. Thanks to Tom Cunningham for patch
Project: http://git-wip-us.apache.org/repos/asf/camel/repo Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/4362bbb0 Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/4362bbb0 Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/4362bbb0 Branch: refs/heads/camel-2.12.x Commit: 4362bbb054cbe3aec8526283ab12f7f402ba05dd Parents: de8fe18 Author: Claus Ibsen <davscl...@apache.org> Authored: Sat Oct 12 12:04:23 2013 +0200 Committer: Claus Ibsen <davscl...@apache.org> Committed: Sat Oct 12 12:04:45 2013 +0200 ---------------------------------------------------------------------- .../component/quartz2/QuartzComponent.java | 3 ++ .../quartz2/QuartUnderscoreTimerNameTest.java | 43 ++++++++++++++++++++ 2 files changed, 46 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/camel/blob/4362bbb0/components/camel-quartz2/src/main/java/org/apache/camel/component/quartz2/QuartzComponent.java ---------------------------------------------------------------------- diff --git a/components/camel-quartz2/src/main/java/org/apache/camel/component/quartz2/QuartzComponent.java b/components/camel-quartz2/src/main/java/org/apache/camel/component/quartz2/QuartzComponent.java index 8215ec2..d3e5e18 100644 --- a/components/camel-quartz2/src/main/java/org/apache/camel/component/quartz2/QuartzComponent.java +++ b/components/camel-quartz2/src/main/java/org/apache/camel/component/quartz2/QuartzComponent.java @@ -236,6 +236,9 @@ public class QuartzComponent extends DefaultComponent implements StartupListener // host can be null if the uri did contain invalid host characters such as an underscore if (host == null) { host = ObjectHelper.before(remaining, "/"); + if (host == null) { + host = remaining; + } } // Trigger group can be optional, if so set it to this context's unique name http://git-wip-us.apache.org/repos/asf/camel/blob/4362bbb0/components/camel-quartz2/src/test/java/org/apache/camel/component/quartz2/QuartUnderscoreTimerNameTest.java ---------------------------------------------------------------------- diff --git a/components/camel-quartz2/src/test/java/org/apache/camel/component/quartz2/QuartUnderscoreTimerNameTest.java b/components/camel-quartz2/src/test/java/org/apache/camel/component/quartz2/QuartUnderscoreTimerNameTest.java new file mode 100644 index 0000000..d7d6c99 --- /dev/null +++ b/components/camel-quartz2/src/test/java/org/apache/camel/component/quartz2/QuartUnderscoreTimerNameTest.java @@ -0,0 +1,43 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.component.quartz2; + +import org.apache.camel.builder.RouteBuilder; +import org.apache.camel.component.mock.MockEndpoint; +import org.apache.camel.test.junit4.CamelTestSupport; +import org.junit.Test; + +public class QuartUnderscoreTimerNameTest extends CamelTestSupport { + + @Test + public void testQuartzCronRouteUnderscore() throws Exception { + MockEndpoint mock = getMockEndpoint("mock:result"); + mock.expectedMinimumMessageCount(1); + + assertMockEndpointsSatisfied(); + } + + @Override + protected RouteBuilder createRouteBuilder() { + return new RouteBuilder() { + public void configure() { + from("quartz2://my_group?cron=0/1+*+*+*+*+?").to("mock:result"); + } + }; + } + +} \ No newline at end of file
