shmakovalexey commented on code in PR #9466: URL: https://github.com/apache/camel/pull/9466#discussion_r1125423107
########## components/camel-micrometer/src/main/java/org/apache/camel/component/micrometer/routepolicy/MicrometerRoutePolicyNamingStrategy.java: ########## @@ -22,15 +22,7 @@ import io.micrometer.core.instrument.Tags; import org.apache.camel.Route; -import static org.apache.camel.component.micrometer.MicrometerConstants.CAMEL_CONTEXT_TAG; -import static org.apache.camel.component.micrometer.MicrometerConstants.DEFAULT_CAMEL_ROUTE_POLICY_EXCHANGES_EXTERNAL_REDELIVERIES_METER_NAME; -import static org.apache.camel.component.micrometer.MicrometerConstants.DEFAULT_CAMEL_ROUTE_POLICY_EXCHANGES_FAILED_METER_NAME; -import static org.apache.camel.component.micrometer.MicrometerConstants.DEFAULT_CAMEL_ROUTE_POLICY_EXCHANGES_FAILURES_HANDLED_METER_NAME; -import static org.apache.camel.component.micrometer.MicrometerConstants.DEFAULT_CAMEL_ROUTE_POLICY_EXCHANGES_SUCCEEDED_METER_NAME; -import static org.apache.camel.component.micrometer.MicrometerConstants.DEFAULT_CAMEL_ROUTE_POLICY_EXCHANGES_TOTAL_METER_NAME; -import static org.apache.camel.component.micrometer.MicrometerConstants.DEFAULT_CAMEL_ROUTE_POLICY_METER_NAME; -import static org.apache.camel.component.micrometer.MicrometerConstants.ROUTE_ID_TAG; -import static org.apache.camel.component.micrometer.MicrometerConstants.SERVICE_NAME; +import static org.apache.camel.component.micrometer.MicrometerConstants.*; Review Comment: No, this is static import in camel-check-style.xml: ```xml <!-- See http://checkstyle.sf.net/config_import.html --> <module name="AvoidStarImport"> <property name="excludes" value="java.io,java.util,java.net,java.nio,java.nio.channels,java.lang.reflect,org.w3c.dom,org.xml.sax,java.awt,javax.swing,junit.framework"/> <property name="allowStaticMemberImports" value="true"/> </module> ``` in plugin description https://checkstyle.sourceforge.io/config_imports.html ``` allowStaticMemberImports - Control whether to allow starred static member imports like import static org.junit.Assert.*;. ``` I run check-style on this component and all OK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
