shmakovalexey commented on PR #9461: URL: https://github.com/apache/camel/pull/9461#issuecomment-1454079602
@essobedo @oscerd I spent 2 days of personal time and just won't leave it) see https://issues.apache.org/jira/browse/CAMEL-19106 Line length in file "_components\camel-spring-ws\src\test\resources\org\apache\camel\component\spring\ws\addresing\ProducerParamsBasicTest-context.xml:60_" is 278 characters There are a lot of XML files in the test resources with lines longer than **250** characters The file "_buildingtools/srcmain/resources/camel-checkstyle.xml:95_" contains the following rule ```xml <module name="LineLength"> <property name="max" value="250"/> </module> ``` maven-checkstyle-plugin settings contain: ```xml <includes>**/*.java,**/*.groovy,**/*.scala,**/*.properties,**/*.xml,**/*.xsd</includes> ``` **How can this rule for check XML not work???** Maybe something is cached on your PC and doesn't work? Please, cd _components\camel-spring-ws_ and make clean and run checkstyle I have Windows 10 and Java 11 on my PC. If everything works on your machine, the problem is deeper than it seemed - in the plugin itself or even in Java 11, and depends on the platform. This will mean that the XML files on your machine are simply not processed by the maven-checkstyle-plugin and it does not check them. Maybe it has something to do with the OS? Is something wrong with Windows? More precisely, on Windows everything works as it should, XML files are checked, but on Linux it doesn't. Because on Windows, the check broke not only test XML files, also in the generated XML file, where forgoted to add a header with a Apache-License. This can be dangerous - you expect XML files to be checked and it doesn't happen. If I'm right - then my solution will of course fix the style errors in the XML, but it will open up a strange issue with style validation on Linux, whose solution no one knows. Well, or maybe everything works for everyone, and I'm just a schizophrenic from the Internet who invents errors that do not exist, and spends too much personal time on its solution. But I am absolutely sure that I am mentally healthy, and that I spent 2 days of my personal time not fighting illusions in my head, but trying to solve the problem of building the project. There is another option to confirm the theory about the problem associated with Windows / Linux - find a PC or Virtual PC with Windows and conduct an experiment on Windows. I'm 99% sure I'm right - the problematic files and settings are the same in _main, camel-3.20, and camel-3.x_. I checked. And since everything works for everyone, it means that no one tried to build on Windows. And checking in XML files just doesn't work on other OS PS - Sorry for my horrible English, I use Google Translate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
