manstis opened a new pull request, #1329:
URL: https://github.com/apache/camel-kamelets/pull/1329

   See https://issues.redhat.com/browse/MGDCTRS-1899
   
   Please advise if you require Camel issues lodged for PRs vs third party 
tracking references.
   
   The underlying Slack Component has deprecated a few 
[parameters](https://camel.apache.org/components/3.20.x/slack-component.html#_path_parameters_1_parameters),
 namely `iconEmoji`, `iconUrl` and `username`.
   
   This PR attempts to reflect the same in the corresponding Kamelet definition.
   
   I'm uncertain if Kamelets even support the definition of deprecated 
parameters. 
[Documentation](https://camel.apache.org/camel-k/1.11.x/kamelets/kamelets-dev.html#_step_6_describe_the_parameters)
 isn't clear.
   
   I'm even less clear, to be honest, whether the `parameters` in a Kamelet map 
to "Components Options" or "Query parameters" or both due to some clever 
name-based mapping in Camel. The three affected Kamelet parameters appear as 
`parameters` in the Kamelet but as "Query parameters" in the Component. The 
Kamelet parameter `webhookUrl` relates to a [Component 
Option](https://camel.apache.org/components/3.20.x/slack-component.html#_component_option_webhookUrl)
 and [Query 
parameter](https://camel.apache.org/components/3.20.x/slack-component.html#_endpoint_query_option_webhookUrl).
   
   I suspect they only map to Component Options and hence the three "Query" 
parameters can be removed entirely and not just deprecated.
   
   Advice welcome.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to