manstis commented on code in PR #1318:
URL: https://github.com/apache/camel-kamelets/pull/1318#discussion_r1120175577
##########
kamelets/telegram-sink.kamelet.yaml:
##########
@@ -60,8 +60,14 @@ spec:
- urn:camel:group:credentials
chatId:
title: Chat ID
- description: The Chat ID to where you want to send messages by
default. Optional if the `chat-id` / `ce-chatid` header is used.
+ description: |-
+ The Chat ID to where you want to send messages by default.
+
+ The Chat ID must be provided for every message; either as a
Configuration Option or a `chat-id` / `ce-chatid` header.
+
+ If the Chat ID is not explicitly provided the default value is used
which may lead to delivery failures.
type: string
+ default: dummy
Review Comment:
This is @valdar's preference.
However I see your point too. Damn. Why do I always see both sides to
things!?!?
The User is forced to either provide a _real_ value for the endpoint
configuration or set its value in the header where it then takes precedence
over the endpoint configuration. The default value is explicitly mentioned in
the updated documentation and advises it _could_ lead to delivery failure.
It's a difficult situation: The parameter is _required_, it is not optional;
but _where_ it can be set (endpoint or per message) means Camel fails to deploy
the Kamelet if the User does not set a value in the Configuration Options when
marked as `required`.
We want to somehow impose configuration of a `chatId` on Users.
I'll chat to @valdar again.. the imposition is something we want in RHOC but
seems contrary to both the underlying Camel Telegram Component and your opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
