manstis commented on PR #1305: URL: https://github.com/apache/camel-kamelets/pull/1305#issuecomment-1448175257
@oscerd I've been thinking on this... This PR made `chat Id` [mandatory](https://github.com/apache/camel-kamelets/pull/1305/files#diff-e4f8e7dc6697309e55f04ee5d0418b45bcfcf3b5d5e1ed1edc0454d1aa21be18R50) which is a breaking change (and is the cause of my re-consideration). I'm thinking it may have been better to simply improve the [description](https://github.com/apache/camel-kamelets/pull/1305/files#diff-e4f8e7dc6697309e55f04ee5d0418b45bcfcf3b5d5e1ed1edc0454d1aa21be18R63) to read along the lines of `chat Id` being required as either a configuration option or supplied in the message header without making it explicitly required. WDYT? Happy to submit more PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
