essobedo commented on code in PR #9332: URL: https://github.com/apache/camel/pull/9332#discussion_r1108919438
########## core/camel-core/src/test/java/org/apache/camel/builder/ExpressionBuilderConcurrencyTest.java: ########## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.builder; + +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import org.apache.camel.ContextTestSupport; +import org.apache.camel.Exchange; +import org.apache.camel.Processor; +import org.apache.camel.component.mock.MockEndpoint; +import org.apache.camel.model.language.SimpleExpression; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.Test; + +public class ExpressionBuilderConcurrencyTest extends ContextTestSupport { + + @Test + public void testConcatExpressionConcurrency() throws Exception { + MockEndpoint mockWithFailure = getMockEndpoint("mock:result"); + mockWithFailure.expectedMessageCount(102); + mockWithFailure.assertIsSatisfied(); + //assertMockEndpointsSatisfied(); Review Comment: Could be removed ########## core/camel-core/src/test/java/org/apache/camel/builder/ExpressionBuilderConcurrencyTest.java: ########## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.builder; + +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import org.apache.camel.ContextTestSupport; +import org.apache.camel.Exchange; +import org.apache.camel.Processor; +import org.apache.camel.component.mock.MockEndpoint; +import org.apache.camel.model.language.SimpleExpression; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.Test; + +public class ExpressionBuilderConcurrencyTest extends ContextTestSupport { + + @Test + public void testConcatExpressionConcurrency() throws Exception { + MockEndpoint mockWithFailure = getMockEndpoint("mock:result"); + mockWithFailure.expectedMessageCount(102); + mockWithFailure.assertIsSatisfied(); + //assertMockEndpointsSatisfied(); + List<Exchange> exchanges = mockWithFailure.getExchanges(); + exchanges.stream() + .forEach(exchange -> Assertions.assertTrue(exchange.getMessage() + .getHeader("#CustomHeader", String.class) + .equals("This is a test a with startLabel: `Document` endLabel: `Document` and label: `ALabel`"))); Review Comment: For clarity, it should rather be a simple `for` loop. Moreover, please use `assertEquals` instead. ########## core/camel-core/src/test/java/org/apache/camel/builder/ExpressionBuilderConcurrencyTest.java: ########## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.builder; + +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import org.apache.camel.ContextTestSupport; +import org.apache.camel.Exchange; +import org.apache.camel.Processor; +import org.apache.camel.component.mock.MockEndpoint; +import org.apache.camel.model.language.SimpleExpression; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.Test; + +public class ExpressionBuilderConcurrencyTest extends ContextTestSupport { + + @Test + public void testConcatExpressionConcurrency() throws Exception { + MockEndpoint mockWithFailure = getMockEndpoint("mock:result"); + mockWithFailure.expectedMessageCount(102); + mockWithFailure.assertIsSatisfied(); + //assertMockEndpointsSatisfied(); + List<Exchange> exchanges = mockWithFailure.getExchanges(); + exchanges.stream() + .forEach(exchange -> Assertions.assertTrue(exchange.getMessage() + .getHeader("#CustomHeader", String.class) + .equals("This is a test a with startLabel: `Document` endLabel: `Document` and label: `ALabel`"))); + } + + @Override + protected RouteBuilder createRouteBuilder() throws Exception { + + return new RouteBuilder() { + Map body = new HashMap() { + { + put("label", "ALabel"); + put("startLabel", "Document"); + put("endLabel", "Document"); + } + }; Review Comment: Let's use, `Map.of("label", "ALabel", "startLabel", "Document", "endLabel", "Document")` instead ########## core/camel-core/src/test/java/org/apache/camel/builder/ExpressionBuilderConcurrencyTest.java: ########## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.builder; + +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import org.apache.camel.ContextTestSupport; +import org.apache.camel.Exchange; +import org.apache.camel.Processor; +import org.apache.camel.component.mock.MockEndpoint; +import org.apache.camel.model.language.SimpleExpression; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.Test; + +public class ExpressionBuilderConcurrencyTest extends ContextTestSupport { + + @Test + public void testConcatExpressionConcurrency() throws Exception { + MockEndpoint mockWithFailure = getMockEndpoint("mock:result"); + mockWithFailure.expectedMessageCount(102); Review Comment: Let's put `100` to avoid making it sound like a magic number -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
