[GitHub] [camel] bvahdat commented on pull request #9341: Avoid using the GlobalOpenTelemetry.get() and allow for injection of …

[via GitHub]

bvahdat commented on PR #9341:
URL: https://github.com/apache/camel/pull/9341#issuecomment-1431494799

   > Did not see any.
   
   Is the review feedback :point_up_2: not visible for you?
   
   ![Screen Shot 2023-02-15 at 15 40 
48](https://user-images.githubusercontent.com/3122177/219059163-8363194d-9a3c-41cd-98cd-87ecb1b4f651.png)
   
   Also I don't see myself by the list of the reviewers of this PR on top 
right. So maybe I am doing something wrong while providing review feedback to 
improve a given PR?
   
   I am asking because the same thing happened by the following PR:
   
   https://github.com/apache/camel/pull/8934
   
   So why I had to provide a follow-up PR for that:
   
   https://github.com/apache/camel/pull/8911
   
   Which actually had to be done by the original author of 
[CAMEL-18661](https://issues.apache.org/jira/browse/CAMEL-18661). Don't you 
think so?
   
   > Also you can just do the change yourself and send a PR if you want 
feedback.
   
   I think it makes more sense for the original author of a JIRA to apply 
suggestions, instead of a reviewer to apply his improvement suggestions 
afterwards as a separate PR as it happened above.
   
   So probably I am doing something wrong while providing feedback to improve a 
given PR?
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org