bvahdat commented on PR #9339: URL: https://github.com/apache/camel/pull/9339#issuecomment-1430119137
> > > One last reason for using the native assert instead of `ObjectHelper.notNull`: the native assert throws an [`AssertionError`](https://docs.oracle.com/javase/8/docs/api/java/lang/AssertionError.html) instead of an [`IllegalArgumentException`](https://docs.oracle.com/javase/8/docs/api/java/lang/IllegalArgumentException.html). > > > As a descendant of `Error` it properly conveys the abnormality of the condition that raised it (granted: many places try to incorrectly catch `Throwable` - but that's a completely different discussion). > > > > > > Thanks for your clarifications. So should I close this PR completely or is there any changes we want to apply? If so which ones? > > Thanks! I don't think you need to close the PR. I think rolling back the ones I mentioned would be enough and then just double checking to make sure we are not replacing the `assert` with `ObjectHelper` in the hot path. @orpiske sorry for not getting back earlier today, as was much busy with other tasks. I think in the meanwhile I have applied all your suggestions, so please verify. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
