essobedo commented on PR #9271: URL: https://github.com/apache/camel/pull/9271#issuecomment-1410587679
> Hey @essobedo are you fine with my comments, so I can merge this? TBH, I'm not really convinced because you replaced a unit test that could be inlined to make a one-line test with 4 lines of code just to avoid throwing an Exception, for me, it is a bit over-engineered. The problem, I see here, is the fact as you duplicate the pattern, to remain homogenous, future similar tests are supposed to apply the same logic which is not really easy to read. But go ahead, if it is fine for you and others, you can merge it as it is my point of view nothing more 😃 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
