orpiske commented on code in PR #9271:
URL: https://github.com/apache/camel/pull/9271#discussion_r1091873006


##########
core/camel-core/src/test/java/org/apache/camel/converter/ConverterTest.java:
##########
@@ -168,38 +174,38 @@ public void testFileToString() throws Exception {
     }
 
     @Test
-    public void testPrimitiveBooleanConversion() throws Exception {
-        boolean value = converter.convertTo(boolean.class, null);
+    public void testPrimitiveBooleanConversion() {
+        boolean value = assertDoesNotThrow(() -> 
converter.convertTo(boolean.class, null));

Review Comment:
   One more thing in favor of the `assertDoesNotThrow` with the fail message: 
we get more details on the CI job in case of failure. That prevents us from 
having to hunt down the logs on the CI. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to