essobedo commented on code in PR #9210:
URL: https://github.com/apache/camel/pull/9210#discussion_r1086982772
##########
components/camel-atmosphere-websocket/src/test/java/org/apache/camel/component/atmosphere/websocket/WebsocketRouteWithInitParamTest.java:
##########
@@ -41,6 +43,8 @@ public class WebsocketRouteWithInitParamTest extends
WebsocketCamelRouterWithIni
private static String[] broadcastMessageTo = {};
private static Map<String, String> connectionKeyUserMap = new HashMap<>();
+ private ExecutorService executor = Executors.newSingleThreadExecutor();
Review Comment:
Where is it used?
##########
components/camel-atmosphere-websocket/src/test/java/org/apache/camel/component/atmosphere/websocket/WebsocketRouteWithInitParamTest.java:
##########
@@ -110,18 +114,18 @@ void
testWebsocketSingleClientBroadcastMultipleClientsGuaranteeDelivery() throws
final int awaitTime = 5;
connectionKeyUserMap.clear();
- WebsocketTestClient wsclient1 = new
WebsocketTestClient("ws://localhost:" + PORT + "/hola3", 2);
- WebsocketTestClient wsclient2 = new
WebsocketTestClient("ws://localhost:" + PORT + "/hola3", 2);
- WebsocketTestClient wsclient3 = new
WebsocketTestClient("ws://localhost:" + PORT + "/hola3", 2);
+ WebsocketTestClient wsclient1 = new
WebsocketTestClient("ws://localhost:" + PORT + "/guarantee", 2);
+ WebsocketTestClient wsclient2 = new
WebsocketTestClient("ws://localhost:" + PORT + "/guarantee", 2);
+ WebsocketTestClient wsclient3 = new
WebsocketTestClient("ws://localhost:" + PORT + "/guarantee", 2);
wsclient1.connect();
- wsclient1.await(awaitTime);
+ wsclient1.await(1);
Review Comment:
Is this change expected?
##########
components/camel-atmosphere-websocket/src/main/java/org/apache/camel/component/atmosphere/websocket/WebsocketEndpoint.java:
##########
@@ -86,15 +86,15 @@ public void setSendToAll(boolean sendToAll) {
this.sendToAll = sendToAll;
}
- public boolean isUseStreaming() {
- return useStreaming;
+ public boolean isStreaming() {
+ return streaming;
}
/**
* To enable streaming to send data as multiple text fragments.
*/
- public void setUseStreaming(boolean useStreaming) {
- this.useStreaming = useStreaming;
+ public void setStreaming(boolean streaming) {
Review Comment:
I hope there is a better way, renaming a property should be avoided
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
