[GitHub] [camel] davsclaus commented on a diff in pull request #9143: CAMEL-14008 Another try to add a connection pool to camel-as2

[GitBox]

davsclaus commented on code in PR #9143:
URL: https://github.com/apache/camel/pull/9143#discussion_r1073217168


##########
components/camel-as2/camel-as2-api/src/main/java/org/apache/camel/component/as2/api/AS2ClientConnection.java:
##########
@@ -41,21 +55,30 @@
 
 public class AS2ClientConnection {
 
+    private static final int RETRIEVE_FROM_CONNECTION_POOL_TIMEOUT_SECONDS = 5;
+
     private HttpHost targetHost;
     private HttpProcessor httpProcessor;
-    private DefaultBHttpClientConnection httpConnection;
     private String as2Version;
     private String userAgent;
     private String clientFqdn;
+    private int connectionTimeoutMilliseconds;
+    private PoolingHttpClientConnectionManager connectionPoolManager;
+    private ConnectionKeepAliveStrategy connectionKeepAliveStrategy;
 
     public AS2ClientConnection(String as2Version, String userAgent, String 
clientFqdn, String targetHostName,
-                               Integer targetPortNumber) throws IOException {
+                               Integer targetPortNumber, Duration 
socketTimeout, Duration connectionTimeout,
+                               Integer connectionPoolMaxSize, Duration 
connectionPoolTtl) throws IOException {
 
         this.as2Version = Args.notNull(as2Version, "as2Version");
         this.userAgent = Args.notNull(userAgent, "userAgent");
         this.clientFqdn = Args.notNull(clientFqdn, "clientFqdn");
         this.targetHost = new HttpHost(
                 Args.notNull(targetHostName, "targetHostName"), 
Args.notNull(targetPortNumber, "targetPortNumber"));
+        Args.notNull(socketTimeout, "socketTimeout");

Review Comment:
   Use Camels ObjectHelper.notNull (in camel-util)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org